-
Notifications
You must be signed in to change notification settings - Fork 3
update to Trixi.jl v0.13 #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
performance_counter has to be given as additional argument in constructor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
==========================================
+ Coverage 91.40% 91.46% +0.05%
==========================================
Files 22 22
Lines 2316 2331 +15
==========================================
+ Hits 2117 2132 +15
Misses 199 199 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This raised a couple of issues:
|
Co-authored-by: Hendrik Ranocha <[email protected]>
|
Could you please check the CI reference values so that tests pass? |
This looks valid, see also trixi-framework/TrixiShallowWater.jl#65 |
tristanmontoya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine now, as far as I can tell; just added some coverage of max_abs_speed_naive for ShallowWaterEquations3D since we left it in. Thanks everyone for making these changes to support Trixi v0.13!
Looking at the breaking changes listed in trixi-framework/Trixi.jl#2422, I expect only the change of the default wave speed estimate may affect TrixiAtmo.jl. Let's see what we get from CI.
(I created this PR before the new version of Trixi.jl is released as a reminder to see what happens.)
Closes #107, closes #108