Skip to content

Conversation

@ranocha
Copy link
Member

@ranocha ranocha commented Jul 21, 2025

Looking at the breaking changes listed in trixi-framework/Trixi.jl#2422, I expect only the change of the default wave speed estimate may affect TrixiAtmo.jl. Let's see what we get from CI.

(I created this PR before the new version of Trixi.jl is released as a reminder to see what happens.)

Closes #107, closes #108

@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.46%. Comparing base (c4394bb) to head (fe7d138).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   91.40%   91.46%   +0.05%     
==========================================
  Files          22       22              
  Lines        2316     2331      +15     
==========================================
+ Hits         2117     2132      +15     
  Misses        199      199              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benegee
Copy link
Collaborator

benegee commented Jul 21, 2025

This raised a couple of issues:

@ranocha
Copy link
Member Author

ranocha commented Jul 22, 2025

Could you please check the CI reference values so that tests pass?

@DanielDoehring
Copy link
Member

* The default wave speed function for Local Lax-Friedrichs was changed to `max_abs_speed` instead of `max_abs_speed_naive`: [Change default wave speed for Local Lax-Friedrichs Trixi.jl#2458](https://github.com/trixi-framework/Trixi.jl/pull/2458)

* I added `max_abs_speed` for `ShallowWaterEquations3D` in analogy to what is done for the Euler equations. If this is ok, we probably still need to adjust reference values.

This looks valid, see also trixi-framework/TrixiShallowWater.jl#65

DanielDoehring
DanielDoehring previously approved these changes Jul 22, 2025
@benegee benegee marked this pull request as ready for review July 22, 2025 20:45
Copy link
Member

@tristanmontoya tristanmontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine now, as far as I can tell; just added some coverage of max_abs_speed_naive for ShallowWaterEquations3D since we left it in. Thanks everyone for making these changes to support Trixi v0.13!

@benegee benegee merged commit 20e069e into main Jul 23, 2025
10 checks passed
@benegee benegee deleted the ranocha-patch-1 branch July 23, 2025 09:12
@benegee benegee mentioned this pull request Jul 23, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants